Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Add CEDAR System UUID #2599

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

ClayBenson94
Copy link
Collaborator

@ClayBenson94 ClayBenson94 commented May 23, 2024

Changes and Description

image

How to test this change

  • Either with mock data or real CEDAR data, navigate to System Profile and ensure the CedarSystem returns a uuid (or null, if the system doesn't have one)

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@ClayBenson94 ClayBenson94 requested review from a team as code owners May 23, 2024 15:04
@ClayBenson94 ClayBenson94 requested review from mynar7, adamodd and samoddball and removed request for a team May 23, 2024 15:04
@ClayBenson94 ClayBenson94 removed the request for review from mynar7 May 23, 2024 15:04
samoddball
samoddball previously approved these changes May 23, 2024
pkg/cedar/core/system_summary.go Outdated Show resolved Hide resolved
samoddball
samoddball previously approved these changes May 23, 2024
@ClayBenson94 ClayBenson94 merged commit d4e73c9 into main May 23, 2024
12 checks passed
@ClayBenson94 ClayBenson94 deleted the NOREF/add_cedar_system_uuid branch May 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants