Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Adding dashboard spec and landing page components #386

Merged
merged 4 commits into from Sep 13, 2022

Conversation

MatthewGotte
Copy link
Contributor

@MatthewGotte MatthewGotte commented Sep 13, 2022

@Lehlohonolo-Sehako I am trying to add the spec for the dashboard back and will need to check why the tests are failing. If you want to work off this branch on your local pc, we can start the design of the landing/about page.

#387
#388

@Lehlohonolo-Sehako
Copy link
Collaborator

@MatthewGotte that sounds perfect.
Will work on increasing coverage in the meantime.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #386 (f82c59f) into develop (d715964) will increase coverage by 1.41%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
+ Coverage    35.15%   36.56%   +1.41%     
===========================================
  Files           82       84       +2     
  Lines         2193     2185       -8     
  Branches       237      235       -2     
===========================================
+ Hits           771      799      +28     
+ Misses        1416     1380      -36     
  Partials         6        6              
Impacted Files Coverage Δ
apps/client/src/app/auth-guard.service.ts 63.63% <ø> (ø)
apps/client/src/app/app.component.ts 77.77% <100.00%> (ø)
...age/feature/src/lib/landing/landing.component.html 100.00% <100.00%> (ø)
...gpage/feature/src/lib/landing/landing.component.ts 100.00% <100.00%> (ø)
...src/lib/workout-invite/workout-invite.component.ts 34.00% <0.00%> (-4.47%) ⬇️
...api-internal-api-repository-data-access.service.ts 17.61% <0.00%> (-0.75%) ⬇️
...g-buddy-api/src/lib/training-buddy-api.resolver.ts 29.65% <0.00%> (-0.15%) ⬇️
...edule/feature/src/lib/workout/workout.component.ts 39.13% <0.00%> (ø)
...ure/src/lib/viewschedule/viewschedule.component.ts 19.16% <0.00%> (ø)
...-service/src/lib/training-buddy-service.service.ts 2.79% <0.00%> (+0.13%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lehlohonolo-Sehako Lehlohonolo-Sehako merged commit a1d5325 into develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants