Hour comparison in num2date is incorrect

[penguian]

In num2date in mod_datetime.f90, line 1245 has:

  if(num2date % hour == 60)then

Surely that comparison should be to 24, not 60?

[russfiedler]

Definitely incorrect code.

[aekiss]

Good catch - this is in the master at wavebitscientific - maybe raise the issue there?
https://github.com/wavebitscientific/datetime-fortran/blob/master/src/lib/mod_datetime.f90#L1238

[penguian]

Done. wavebitscientific#64

[aekiss]

This mix of integer and real arithmetic makes me nervous too.
But I think I'm right in saying 1e3 has an exact representation as a float, so I guess that helps...
https://github.com/wavebitscientific/datetime-fortran/blob/master/src/lib/mod_datetime.f90#L1215-L1228