Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username is used for http-basic instead of user_id #162

Closed
MaartendeKruijf opened this issue May 21, 2024 · 0 comments · Fixed by #163
Closed

Username is used for http-basic instead of user_id #162

MaartendeKruijf opened this issue May 21, 2024 · 0 comments · Fixed by #163
Assignees
@MaartendeKruijf
Labels
bug Something isn't working
Milestone
SOARCA 1.1

Comments

@MaartendeKruijf
Copy link
Collaborator

Describe the bug

spec states we should user_id

image

we ar using request.SetBasicAuth(httpOptions.Auth.Username, httpOptions.Auth.Password)

SOARCA/utils/http/http.go

Line 173 in 1d96431

request.SetBasicAuth(httpOptions.Auth.Username, httpOptions.Auth.Password)

@MaartendeKruijf MaartendeKruijf added the bug Something isn't working label May 21, 2024
@MaartendeKruijf MaartendeKruijf added this to the SOARCA 1.1 milestone May 21, 2024
@MaartendeKruijf MaartendeKruijf self-assigned this May 21, 2024
@MaartendeKruijf MaartendeKruijf linked a pull request May 21, 2024 that will close this issue
replaced username with user_id #163
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaartendeKruijf MaartendeKruijf

Labels
bug Something isn't working
Projects
None yet
Milestone
SOARCA 1.1
Development

Successfully merging a pull request may close this issue.

replaced username with user_id COSSAS/SOARCA
1 participant
@MaartendeKruijf