Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce consistent usage of quotes #599

Open
erikbosch opened this issue May 8, 2023 · 0 comments
Open

Enforce consistent usage of quotes #599

erikbosch opened this issue May 8, 2023 · 0 comments

Comments

@erikbosch
Copy link
Collaborator

erikbosch commented May 8, 2023

We have a recommendation that single quotes shall be used for string literals. But it is not consistently used. In most cases it has no practical consequence - the *.vspec files are based on Yaml and there can be a slight difference in meaning between single and double quotes, but should for most of our usage not matter.

Idea:

  • Change syntax/rules so that single quotes are needed
  • Add a feature in vss-tools so that an error (or warning) is given if quotes are not used as expected. Like checking all string literals.

But the philosophical question here is:

  • Do we want Yaml to be "part" of VSS *.vspec syntax, i.e. that all Yaml-constructs for quoting/escaping are valid in VSS as well. The advantage with this approach is that we do not even need to care as long as we start with using a Yaml parser and only sees the result after parsing
  • Or do we want VSS to have it's own syntax, which just "by coincidence" happen to be an "extended subset" of Yaml.?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant