Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Coverage test failing with Moo 1.005 #16

Closed
pghmcfc opened this issue Jul 29, 2014 · 3 comments
Closed

Pod Coverage test failing with Moo 1.005 #16

pghmcfc opened this issue Jul 29, 2014 · 3 comments
Labels

Comments

@pghmcfc
Copy link

pghmcfc commented Jul 29, 2014

Not sure if this is an issue with MetaCPAN-Client, Moo or Pod-Coverage so I'll start here and see where it goes. Since update Moo from 1.003x to 1.005, MetaCPAN-Client's Pod Coverage test fails like this:

$ make test AUTHOR_TESTING=1 RELEASE_TESTING=1
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/api/*.t
t/00-compile.t ............ ok
t/api/_get.t .............. ok
t/api/_get_or_search.t .... ok
t/api/_search.t ........... ok
t/api/author.t ............ ok
t/api/distribution.t ...... ok
t/api/favorite.t .......... ok
t/api/file.t .............. ok
t/api/module.t ............ ok
t/api/pod.t ............... ok
t/api/rating.t ............ ok
t/api/release.t ........... ok
t/author-critic.t ......... ok
t/entity.t ................ ok
#   Failed test 'Pod coverage on MetaCPAN::Client::ResultSet'
#   at /usr/share/perl5/vendor_perl/Test/Pod/Coverage.pm line 133.
# Coverage for MetaCPAN::Client::ResultSet is 87.5%, with 1 naked subroutine:
#       has_scroller
# Looks like you failed 1 test of 12.
t/release-pod-coverage.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/12 subtests
t/release-pod-syntax.t .... ok
t/request.t ............... ok
t/resultset.t ............. ok
Test Summary Report
-------------------
t/release-pod-coverage.t (Wstat: 256 Tests: 12 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
Files=18, Tests=203, 10 wallclock secs ( 0.07 usr  0.01 sys +  6.20 cusr  0.35 csys =  6.63 CPU)
Result: FAIL
Failed 1/18 test programs. 1/203 subtests failed.
Makefile:838: recipe for target 'test_dynamic' failed
make: *** [test_dynamic] Error 255

has_scroller seems to be being pulled in from Search::Elasticsearch so I don't really think there should be pod for it in MetaCPAN::Client. Perhaps Pod-Coverage should be ignoring this somehow? Any suggestions?

(yes, I know I don't need to run the author/release tests but there's a bug here somewhere and I'd like to help get it fixed)

@kentfredric
Copy link
Contributor

It appears this bug was fixed in 1.007001 , as it snuck in to commit 6a140f1

https://metacpan.org/diff/file?target=MICKEY/MetaCPAN-Client-1.007001/&source=MICKEY/MetaCPAN-Client-1.007000/#lib/MetaCPAN/Client/ResultSet.pm

Can you confirm?

@mickeyn
Copy link
Contributor

mickeyn commented Oct 10, 2014

yes. I fixed it while releasing (as I saw the same failure mentioned).

@xsawyerx xsawyerx added the bug label Jan 1, 2015
@mickeyn
Copy link
Contributor

mickeyn commented Apr 10, 2015

cleaning up the 'issues'.

@mickeyn mickeyn closed this as completed Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants