New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make example scripts distributed with a release more prominent #741
Conversation
Have you tried extending https://github.com/CPAN-API/metacpan-web/blob/master/lib/MetaCPAN/Web/Model/API/Release.pm#L247 ? that would safe us a roundtrip to the api and I don't see a reason why that shouldn't work. |
I'll investigate that option. |
I have some commits to push to the api later that might fix that diff issue |
@rwstauner do you know when/how that regression was introduced? It certainly worked at some point. |
I found an issue on my dev machine where the diff paths were getting truncated and I think the difference (b/t working and not) is a difference of environment. I believe I have fixed that though (locally). |
Nevermind. I deployed the api changes and https://metacpan.org/diff/file/?target=DOY/Moose-2.0202/lib/Moose.pm&source=DOY/Moose-2.0201/lib/Moose.pm is still missing the file names. |
@tobyink I fixed the api; the diff should display correctly for you now. Thanks. |
I also fixed the test in this repo. |
I've pulled in all kinds of upstream stuff, and it now passes all tests. |
Make example scripts distributed with a release more prominent
Thanks very much for this. My apologies that we lost track of it. Please don't let that discourage any future contributions. This is a very helpful addition. 👍 |
thank you very much! |
Many authors distribute example scripts with their releases.
Here is a small patch to include a list of examples on the release info page.