Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test File paths Indexing is ambiguous #305

Open
manoskary opened this issue Aug 4, 2023 · 3 comments
Open

Test File paths Indexing is ambiguous #305

manoskary opened this issue Aug 4, 2023 · 3 comments
Labels
invalid This doesn't seem right

Comments

@manoskary
Copy link
Member

Hello, with this issue I would like to address the way the partitura tests are handled. This issue doesn't actually concern the partitura package code but only the test handling. We've been using pre-defined paths in the tests init and indexing the files that correspond to the actual file we would like to test for each one of the unit-tests. However, adding or removing test example files can perturb this indexing and moreover, we don't always know what file we are running the test on. I propose we change all the unit-tests with another solution to remove the indices, maybe calling the files by name would be a better option.

@manoskary manoskary added the invalid This doesn't seem right label Aug 4, 2023
@fosfrancesco
Copy link
Collaborator

I'm in favour of just using the local path to the file. It will make things much easier. However, we need to find a solution for the tests that run on a larger set of scores, like the load_score test. Maybe in the test init we can have a function which takes all the files divided by folder.

@manoskary
Copy link
Member Author

It will take some time, but maybe we can start fixing it for the next release (1.3.3)

Copy link

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?

@github-actions github-actions bot added the stale label Mar 12, 2024
@manoskary manoskary removed the stale label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants