Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globbing is too greedy #8

Open
dwenzel opened this issue Apr 23, 2019 · 0 comments
Open

globbing is too greedy #8

dwenzel opened this issue Apr 23, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dwenzel
Copy link
Member

dwenzel commented Apr 23, 2019

It seems that the rename task always processes any file (matching a given name) in all subfolders of the current working directory.

Example

 "extra": {
   "setup-helper": [
       "replace": [
         {
           "ask": "foo question",
           "search": "{{firstPattern}}",
           "path": "./*.{json,md}"
         },
         {
           "ask": "better question: ",
           "search": "{{secondPattern}}",
           "path": "composer.json"
         }
       ]
     }
   ]
 }

expected:

  • search for "{{firstPattern}}" in all files of the current working directory without subdirectories where the name ends with .json or .md
  • search for "{{secondPattern}}" in the file composer.json in the current directory only

observed:

  • searches "{{firstPattern}}" in all files of the current working directory and its subdirectories where the name ends with .json or .md
  • search "{{secondPattern}}" in the file composer.json in the current directory and all files named composer.json in all subdirectories
@dwenzel dwenzel added the bug Something isn't working label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants