Add game pin generation functionality #12
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mmpotulo28 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| function generatePIN() { | ||
| let digits = Math.floor(1000 + Math.random() * 9000); | ||
|
|
||
| let letters = ''; | ||
| const alphabet = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'; | ||
| for (let i = 0; i < 3; i++) { | ||
| letters += alphabet.charAt(Math.floor(Math.random() * alphabet.length)); | ||
| } | ||
|
|
||
| let pin = digits + letters; | ||
|
|
||
| document.getElementById('pinDisplay').value = pin; | ||
| sessionStorage.setItem('gamePin', pin); | ||
| } |
There was a problem hiding this comment.
🚨 suggestion (security): Consider using a more secure random generator for PINs.
The current method using Math.random is not cryptographically secure, which might be a concern for the application's security requirements.
| } | ||
|
|
||
| window.onload = function () { | ||
| let storedPin = sessionStorage.getItem('gamePIN'); |
There was a problem hiding this comment.
issue (bug_risk): Mismatch in case sensitivity for sessionStorage key.
The key 'gamePIN' used in getItem does not match the case of 'gamePin' used in setItem, which could lead to unexpected behavior.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Deploying devpost-hackathon with
|
| Latest commit: |
8a60b6a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b148018.devpost-hackathon.pages.dev |
| Branch Preview URL: | https://sam.devpost-hackathon.pages.dev |
There was a problem hiding this comment.
@samkeleN address the changes suggested by the AI
issue (bug_risk): Mismatch in case sensitivity for sessionStorage key.
The key 'gamePIN' used in getItem does not match the case of 'gamePin' used in setItem, which could lead to unexpected behavior.
|
reopen this PR after you made the requested changes |
No description provided.