New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection timeout bug in search API #550
Comments
Additional note: The error might occur in the first place because of the long search windows and only 5s timeout. |
Hello @ds2268 and thanks for submitting this issue. That's right, the |
@sbrunato : Do you have any idea when the fix can be expected in order for me to know how much to catch such exceptions on my side with ad-hoc patches? |
I think this can be fixed by the end of november, but there are no guarantees |
I've just run into this issue too. I believe it's caused by a call to Could be fixed by returning an empty list in With Alternatively testing for if(results is None):
normalize_remaining_count = len(results)
else:
normalize_remaining_count = 0 has the same effect as the other fix. Happy to submit a patch for this |
@catchSheep: I like the first approach better. An empty list should probably mimic better the situation when there is a timeout error. The only missing thing would be in knowing that that happened and not that there are no results that could be found. An alternative would be to properly propagate the timeout exception all the way back to the user. This approach would probably be the most transparent. |
Thanks for the suggestions @catchSheep and @ds2268 . The thing to do here is to make |
Describe the bug
No result from provider 'creodias' due to an error during the search.
urllib3.exceptions.ConnectTimeoutError: (<urllib3.connection.HTTPSConnection object at 0x7f0614fa07f0>, 'Connection to finder.creodias.eu timed out. (connect timeout=5)')
Timeout error is not properly handled and propagated back. The error (len() of None) appears already inside the eodag code:
Code To Reproduce
all_products = session.search_all(**search_criteria)
-> with the specific search and creodias provider for example.Output
Environment:
Additional context
The above error appeared in a large-scale search for 50k different searches. The error appeared on a specific search, after 10s of thousands of successful searches.
The text was updated successfully, but these errors were encountered: