Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple names allowed #157

Closed
nus-pe-script opened this issue Nov 2, 2018 · 1 comment
Closed

Multiple names allowed #157

nus-pe-script opened this issue Nov 2, 2018 · 1 comment
Assignees
Labels
severity.low A flaw that is unlikely to affect normal operations of the product. type.bug A bug
Milestone

Comments

@nus-pe-script
Copy link

Describe the bug
The same person can be added to the member list when I type in the same person's name in a separate command but in different casing.

To Reproduce
Steps to reproduce the behavior:

  1. Type: addmember kang ting and press "ENTER".
  2. Type addmember Kang Ting and press "ENTER".
  3. Type listmembers and press "ENTER".
  4. See error
    image

Expected behavior
Message should output "This member already exists in the address book", as it happens when I type the same person's name in the same letter casing. However, when I type the same person's name of different casing (see the steps above), the expected behavior does not show.


Reported by: @jylee-git
Severity: High

[original: nusCS2113-AY1819S1/pe-1#284]

@px1099 px1099 added type.bug A bug severity.low A flaw that is unlikely to affect normal operations of the product. labels Nov 3, 2018
@px1099 px1099 added this to the v1.4 milestone Nov 3, 2018
@kangmingtay
Copy link
Collaborator

I'll add another field called phone number so there's more differentiation between 2 members with the same name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.low A flaw that is unlikely to affect normal operations of the product. type.bug A bug
Projects
None yet
Development

No branches or pull requests

3 participants