Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clockIn and clockOut when employees have the same name #159

Closed
nus-pe-script opened this issue Nov 2, 2018 · 0 comments
Closed

clockIn and clockOut when employees have the same name #159

nus-pe-script opened this issue Nov 2, 2018 · 0 comments
Assignees
Labels
severity.low A flaw that is unlikely to affect normal operations of the product. type.bug A bug
Milestone

Comments

@nus-pe-script
Copy link

Describe the bug
RMS allows users to add employees with the same name. However, clockIn and clockOut only accepts a name parameter. It is thus unclear which employee is being clocked in or out.

To Reproduce
Steps to reproduce the behavior:

  1. Add two employees to the system with the same name (but different parameters, such as phone number).
  2. Execute the clockIn command.

Expected behavior
It is not clear what is supposed to happen in this case. Do all the employees with the same name clock in? Or does the first instance of the employee clock in?

Screenshots
Running listemp with 4 employees with the same name added.
image

Running clockIn John Doe:
image


Reported by: @nianfei97
Severity: High

[original: nusCS2113-AY1819S1/pe-1#372]

@px1099 px1099 added type.bug A bug severity.low A flaw that is unlikely to affect normal operations of the product. labels Nov 3, 2018
@px1099 px1099 added this to the v1.4 milestone Nov 3, 2018
@px1099 px1099 mentioned this issue Nov 3, 2018
@px1099 px1099 closed this as completed Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.low A flaw that is unlikely to affect normal operations of the product. type.bug A bug
Projects
None yet
Development

No branches or pull requests

4 participants