Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addAdmin command isn't working as expected #107

Closed
nus-pe-script opened this issue Nov 2, 2018 · 3 comments
Closed

addAdmin command isn't working as expected #107

nus-pe-script opened this issue Nov 2, 2018 · 3 comments
Assignees
Labels
severity.Medium type.bug Something isn't working
Milestone

Comments

@nus-pe-script
Copy link

Describe the bug
Shows an error message when you type in 'addAdmin jane Software2! Software2!' even though the password meets the requirements

To Reproduce
Steps to reproduce the behavior:

  1. open jar file
  2. login with default userid and password
  3. type in 'addAdmin jane Software2! Software2!' and enter
  4. See error

Expected behavior
expected to see a successful account made message

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Add any other context about the problem here.


Reported by: @sanjukta99
Severity: Medium

[original: nusCS2113-AY1819S1/pe-1#252]

@Psyf Psyf self-assigned this Nov 3, 2018
@Psyf Psyf added type.bug Something isn't working severity.Medium labels Nov 3, 2018
@Psyf Psyf added this to the v1.4.1 milestone Nov 3, 2018
@Psyf
Copy link

Psyf commented Nov 3, 2018

Thank you for pointing it out.
I'll look into it.

@trufflepirate
Copy link

@saif, yeah your! Is illegal char

@Psyf
Copy link

Psyf commented Nov 3, 2018

@trufflepirate yep just realized only legal ones are [@#$%^&+=]
Updating the addAdmin help prompt accordingly.

P.S that's not my account. I'm at @Psyf haha

Addressed in #129

@Psyf Psyf closed this as completed Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants