Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No exception handling for invalid dates for the addhist function #154

Closed
nus-pe-script opened this issue Nov 2, 2018 · 1 comment
Closed
Assignees
Labels
severity.high type.bug Something isn't working
Milestone

Comments

@nus-pe-script
Copy link

Describe the bug
inputting an invalid date will cause the application to stall and return a result
To Reproduce
Steps to reproduce the behavior:
enter an invalid date after the hsd tag ie:
addhist 1 hsd/99-99-9999

Expected behavior
invalid date exception
Screenshots
image

Additional context
Add any other context about the problem here.


Reported by: @BearPerson1
Severity: High

[original: nusCS2113-AY1819S1/pe-1#172]

@xShaivan xShaivan added type.bug Something isn't working severity.high labels Nov 3, 2018
@xShaivan xShaivan added this to To do in CS2113 AddressBook Project via automation Nov 3, 2018
@xShaivan xShaivan added this to the v1.4 milestone Nov 3, 2018
@xShaivan
Copy link

xShaivan commented Nov 4, 2018

Our team has implemented a standardized date/time check which resolves this issue and will be found in the v1.4 release. Thank you for the feedback!

@xShaivan xShaivan closed this as completed Nov 4, 2018
CS2113 AddressBook Project automation moved this from To do to Done Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.high type.bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants