Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to add invalid date for reminders #133

Closed
nus-pe-script opened this issue Nov 2, 2018 · 2 comments
Closed

Able to add invalid date for reminders #133

nus-pe-script opened this issue Nov 2, 2018 · 2 comments
Assignees
@ParasK26

Comments

@nus-pe-script
Copy link

Describe the bug
Invalid date with day being 31 (e.g. Nov 31) is accepted for adding of reminders with the addreminder command

To Reproduce
Steps to reproduce the behavior:

  1. Register and login
  2. Add a reminder with date 2019/11/32 as shown in the screenshot
  3. See success message

Expected behavior
Error message to be shown prompting for valid date

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Add any other context about the problem here.

Reported by: @chiaxr
Severity: Medium

[original: nusCS2113-AY1819S1/pe-1#478]
@amirulmaricar
Copy link
Collaborator

Follows #132

@ParasK26 ParasK26 mentioned this issue Nov 7, 2018
Merged
@ParasK26
Copy link

ParasK26 commented Nov 7, 2018

Fixed in PR #157

@ParasK26 ParasK26 closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ParasK26 ParasK26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amirulmaricar @ParasK26 @nus-pe-script