Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Processer #121

Closed

Conversation

junweiljw
Copy link

Added a Processor class that filters and rearranges the user's input before returning it to addressbookParser to be parsed

To do:

  • Test cases
  • Update user guide

- Parses user input before returning to AddressbookParser for Matcher class to handle
- Parses user input before returning to AddressbookParser for Matcher class to handle
@junweiljw junweiljw added the priority.high Must do label Oct 29, 2018
@junweiljw junweiljw added this to the v1.3 milestone Oct 29, 2018
@junweiljw junweiljw self-assigned this Oct 29, 2018
- Parses user input before returning to AddressbookParser for Matcher class to handle
- Parses user input before returning to AddressbookParser for Matcher class to handle
- Parses user input before returning to AddressbookParser for Matcher class to handle
@junweiljw
Copy link
Author

It is failing some test cases, can somebody help me on this?

Copy link

@linnnruoo linnnruoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processor class failed all the parser tests, incorrect command format is being parsed.

@junweiljw
Copy link
Author

Going to close this PR, updated with Processor 2.0 #126

@junweiljw junweiljw closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants