Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify calendar #189

Merged
merged 4 commits into from Nov 11, 2018
Merged

modify calendar #189

merged 4 commits into from Nov 11, 2018

Conversation

linnnruoo
Copy link

removed some unnecessary codes and credited the original author

@linnnruoo linnnruoo added this to the v1.4 milestone Nov 11, 2018
@coveralls
Copy link

coveralls commented Nov 11, 2018 •
edited

Coverage Status

Coverage increased (+0.3%) to 82.419% when pulling 0171710 on linnnruoo:hardcode_calendar into a6d0001 on CS2113-AY1819S1-W12-1:master.

@linnnruoo linnnruoo mentioned this pull request Nov 11, 2018
Closed
jitwei98
jitwei98 requested changes Nov 11, 2018
View reviewed changes
Copy link
Collaborator

@jitwei98 jitwei98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new features work, however they're some typo in the code, understandable considering the time given

src/main/java/seedu/address/ui/CalendarLayout.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/ui/CalendarLayout.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/ui/CalendarLayout.java Outdated Show resolved Hide resolved
@jitwei98 jitwei98 merged commit 0353c5d into CS2113-AY1819S1-W12-1:master Nov 11, 2018
@linnnruoo linnnruoo mentioned this pull request Nov 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitwei98 jitwei98 jitwei98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linnnruoo @coveralls @jitwei98