Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Command Bug #154

Closed
nus-pe-script opened this issue Nov 2, 2018 · 1 comment
Closed

Find Command Bug #154

nus-pe-script opened this issue Nov 2, 2018 · 1 comment
Assignees

Comments

@nus-pe-script
Copy link

Describe the bug
A clear and concise description of what the bug is.

The find bug command when searched for phone number, returned wrong person with the incorrect phone number

To Reproduce
Steps to reproduce the behavior:

  1. Key "add n/John Doe p/912 e/johnd@example.com a/311, Clementi Ave 2, Added references list #2-25 r/Secretary k/3.2 d/John is forgetful t/friends 2" in the command line.
  2. Key 'find p/910'
    3.Command result box shows "1 person listed"
  3. The list panel shows the john doe who is added with phone number 912.

Expected behavior
A clear and concise description of what you expected to happen:
When "find p/910" is entered, the command result box should have shown "0 person listed" since no one has the phone number "910". The list panel shouldn't have shown John Doe with phone number "912".

Screenshots
image

Showing wrong person with incorrect phone number. Should have return an empty list instead.
image

Additional context
Add any other context about the problem here.


Reported by: @ChanChunCheong
Severity: Medium

[original: nusCS2113-AY1819S1/pe-1#704]

@lekoook lekoook assigned lws803 and Limminghong and unassigned Limminghong Nov 2, 2018
@lws803
Copy link

lws803 commented Nov 5, 2018

Will resolve with a new indicator of how many actual keyword matches and how many are guessed contacts.

@lws803 lws803 closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants