Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to disable stretching view to more than set height. #137

Merged
merged 1 commit into from Sep 12, 2016

Conversation

Luzo
Copy link
Collaborator

@Luzo Luzo commented Jul 24, 2016

For me header was always stretching to more than set size which was not desired behaviour. So I added option to disable this.

Thank you for possible merge.

@ShawnBaek
Copy link
Collaborator

Hi I think It still stretching the header view..

if let layout = self.collectionViewLayout as? CSStickyHeaderFlowLayout {
layout.parallaxHeaderReferenceSize = CGSizeMake(self.view.frame.size.width, 215)

        layout.parallaxHeaderMinimumReferenceSize = CGSizeMake(self.view.frame.size.width, 215)

// layout.itemSize = CGSizeMake(self.view.frame.size.width, 40)
layout.parallaxHeaderAlwaysOnTop = false
layout.disableStickyHeaders = true
}

Could you advising me how to use that?

@Luzo
Copy link
Collaborator Author

Luzo commented Aug 16, 2016

Hi, you just have to set disableStretching property on layout to true. I am not sure, but setting item size might be necessary.

Hope that it helps.

@ShawnBaek
Copy link
Collaborator

Thanks for the reply

I want implement like an spotify example(CSsticky example 1)

As you can see it seems not the stretch

Do you mean your commit set this feature right?

나의 iPhone에서 보냄

Aug 16, 2016 9:11 PM Luzo notifications@github.com 작성:

Hi, you just have to set disableStretching property on layout to true. I am not sure, but setting item size might be necessary.

Hope that it helps.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@Luzo
Copy link
Collaborator Author

Luzo commented Aug 17, 2016

If you want no overstretching then yes. If stretching over the maximum size is not your problem, then it will not help you. In the second scenario I suggest you to run the project, it contains samples .Probably you will find there wished behaviour.

@ShawnBaek
Copy link
Collaborator

Hi Thanks for the reply.

I understand…your code is not stretched.

here is my code..

I had already set the like this.. layout.disablestretching = true

if let layout = self.collectionViewLayout as? CSStickyHeaderFlowLayout {
layout.parallaxHeaderReferenceSize = CGSizeMake(self.view.frame.size.width, 215)

        layout.parallaxHeaderMinimumReferenceSize = CGSizeMake(self.view.frame.size.width, 215)
        layout.parallaxHeaderAlwaysOnTop = false
        layout.disableStretching = true
    }

Um..My problem is… when I trying to scroll down then… parallaxHeader is not moved….yes it is not stretched..really great.

But Is it possible If I scroll down then…parallaxHeader also move down…following the UICollectionView’s section header top

like this example..

Thank you so much

    1. 17., 오후 3:43, Luzo <notifications@github.com mailto:notifications@github.com> 작성:

If you want no overstretching then yes. If stretching over the maximum size is not your problem, then it will not help you. In the second scenario I suggest you to run the project, it contains samples .Probably you will find there wished behaviour.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #137 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AMDtdDymvnndW1sMiNsAVlMHWbSLFGcFks5qgq2vgaJpZM4JTjjm.

@Luzo
Copy link
Collaborator Author

Luzo commented Aug 18, 2016

I am not sure what do you mean with it should move down. Like you want it to expand?

@ShawnBaek
Copy link
Collaborator

Can I send gif images to you via email? I means parallax header's top is not detached the navigation bar's bottom. But I want fix the parallax header's height and detach from navigationbars. Sorry for not clear my questions.

@jamztang
Copy link
Collaborator

Hi @Luzo, I've migrate the project to under an organization, hopefully to let the community to be happy to be part of the owner of this library. Please forgive my lack of time to continue maintain the library, allow me to add you as a contributor, so we can move things forward.

@Luzo Luzo merged commit d749b53 into CSStickyHeaderFlowLayout:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants