Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tensor encoding/decoding into the Index class #137

Open
kylebgorman opened this issue Aug 29, 2023 · 0 comments
Open

Move tensor encoding/decoding into the Index class #137

kylebgorman opened this issue Aug 29, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kylebgorman
Copy link
Contributor

This is a notice of my plans to move the encoding methods (which take strings and make tensors) and decoding methods (which convert tensors back into strings) into the Index class itself. Currently this ability lives inside of the DataSet class and I really don't know why it belongs there. This should substantially reduce weird coupling, like for instance what happens here with all those chained method calls.

As part of this, the Index class will have two class methods, one which reads the index from a .pkl file, and one which constructs the index from a list of file handles. This latter should give me a place to compute max tensor sizes, as needed for #50.

I also think the index will then become a better object to unit test.

@kylebgorman kylebgorman added the enhancement New feature or request label Aug 29, 2023
@kylebgorman kylebgorman self-assigned this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant