Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shouldSelect option in togglePresentedDate method #606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoobato
Copy link

@yoobato yoobato commented May 22, 2021

Add shouldSelect option parameter in togglePresentedDate method.
This determines whether selectDayViewWithDay method where is in the end of togglePresentedDate method should be called or not.

I set true as default value for shouldSelect to support legacy codes.

AS-IS (CVCalendarContentViewController)
@objc public func togglePresentedDate(_ date: Foundation.Date) { }

TO-BE
@objc public func togglePresentedDate(_ date: Foundation.Date, shouldSelect: Bool = true) { }

This may helps #251 although it's closed.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Thank you for your contributions.

@stale stale bot added the Stale label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant