Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Lances: Elite lances always being used #503

Closed
CWolfs opened this issue Apr 13, 2022 · 1 comment
Closed

Additional Lances: Elite lances always being used #503

CWolfs opened this issue Apr 13, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@CWolfs
Copy link
Owner

CWolfs commented Apr 13, 2022

There is a bug where elite lances would always be used due to a bad default setup value of true instead of false.

What would usually happen is this:

  • Because the modpack/modder hadn't set up elite lances (because they didn't intend to use the feature), MC would look for the elite lance and not find it.
  • MC would fallback to the usual expected lance instead (so this hid the problem for 3 years!)
  • MC would modify the difficulty of the selected lance slightly
@CWolfs CWolfs added the bug Something isn't working label Apr 13, 2022
@CWolfs CWolfs added this to the v1.5.0 milestone Apr 13, 2022
@CWolfs
Copy link
Owner Author

CWolfs commented Apr 13, 2022

In develop and a dll fix is in Discord known-issues channel if required.

@CWolfs CWolfs closed this as completed Apr 13, 2022
@CWolfs CWolfs modified the milestones: v1.5.0, v1.4.2 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant