Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor project to use "-label.json" as a marker #2

Closed
CXwudi opened this issue Feb 21, 2021 · 1 comment
Closed

refactor project to use "-label.json" as a marker #2

CXwudi opened this issue Feb 21, 2021 · 1 comment

Comments

@CXwudi
Copy link
Owner

CXwudi commented Feb 21, 2021

  • instead of scanning -songInfo.json, we should use a dedicated JSON file with all other necessary info for the next module to proceed. The JSON info also includes any filenames associated with the song (including songInfo.json file)
  • this can also fix the issue: to implement an advanced audio extractor choosing strategy, we need information from the previous module.
  • don't write too many util functions for labels, instead, each module has its own helpers (reason: for better extendibility)
  • also don't be confused that this label JSON is used to record necessary info and parameters that the next module needs
@CXwudi CXwudi created this issue from a note in Further Completion (To do) Feb 21, 2021
@CXwudi CXwudi changed the title refactor project to use -label.json as a marker refactor project to use "-label.json" as a marker Feb 21, 2021
@CXwudi CXwudi removed this from To do in Further Completion Mar 27, 2021
@CXwudi
Copy link
Owner Author

CXwudi commented Jul 25, 2022

At this stage, we are pretty sure we are using "-label" JSON all the time

@CXwudi CXwudi closed this as completed Jul 25, 2022
After-completion Improvement automation moved this from To do to Done Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant