Changing lists while making an analysis cause errors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexList and extensionsList are passed as a reference to the Scanner. The Scanner uses them while scanning, but if they changed while scanning problems occur. With this fix, when an analysis is started, a copy of the current state is saved. Then, the Scanner uses this copy instead of the original list so that it can be changed without interferring with the analysis.
ghost
added
the
ghost
requested a review
from 
alessiodallapiazza
approved these changes
Nov 23, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexList and extensionsList are passed as a reference to the Scanner. The Scanner uses them while scanning, but if they change while scanning, problems occur.
With this fix, when an analysis is started, a copy of the current state is saved. Then, the Scanner uses this copy instead of the original list so that changes don't interfere with the analysis.