Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild.SDK.SystemWeb.RazorLibrary does not support GeneratedBindingRedirectsAction feature #58

Open
CZEMacLeod opened this issue Apr 3, 2023 · 0 comments · May be fixed by #61
Open
Assignees
Labels
enhancement New feature or request

Comments

@CZEMacLeod
Copy link
Owner

The MSBuild.SDK.SystemWeb.RazorLibrary SDK type only obeys OverwriteAppConfigWithBindingRedirects and does not have the enhanced functionality of MSBuild.SDK.SystemWeb and GeneratedBindingRedirectsAction which was added in #36 to address #34.

We should copy the base functions of MSBuild.SDK.SystemWeb.BindingRedirects.targets to the Razor SDK type.

In the case of an MVC based project, it is often required to have a separate web.config in the Views directory and any Area's Views directory.

In the Razor SDK this is handled with an item type of RazorAppConfigFiles and an XmlPeek / XmlPoke for each file in the target that updates the main web.config file.

Now that we have a common files mechanism, and the fact you may have such additional web.config files in the main 'head' application, it would make sense to make this a combined/common feature.

@CZEMacLeod CZEMacLeod self-assigned this Apr 3, 2023
@CZEMacLeod CZEMacLeod added the enhancement New feature or request label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant