-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of tdor data #7
Comments
If it would help, I'd be happy to update the readme.md for the CSV repo on BitBucket to include data on what each column represents and the data type. Would that help? |
That would be good, as it would help anyone that gets the data from Bitbucket (not everyone uses R!). You can see what we have at the moment in https://github.com/CaRdiffR/tdor/blob/master/R/tdor.R. Most variables are obvious (or they are variables we created ourselves), I think the main questions to clear up are:
|
I'm not sure what "Source" is but it's likely a typo - can you point me at where in the data it appears? "TGEU ref" is a deprecated field which has just been replaced by "Source ref" in the CSV data on Bitbucket. It's basically a string which shows where to find the corresponding entry in the corresponding TDoR list. If it's blank, it means that the entry doesn't appear (or hasn't yet) in a TDoR list. |
"Source" has been fixed, it was supposed to be "Description". "TGEU ref" (and "Source Ref") are now merged with "Source ref" when the data is prepared for the package, but a PR has been made to correct these in the Bitbucket source. The documentation has been updated with the variable descriptions. Adding an example can be a separate issue. |
Make sure we have good description of each variable. Include a simple example. Is a reference the right way to note the source?
The text was updated successfully, but these errors were encountered: