Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When links are convert to ajax calls, mailto links should not be included #2718

Closed
ddb4github opened this issue Jun 2, 2019 · 0 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

'mailto' hyperlink is not workable

Prefer diff like:

--- cacti/include/layout.js     2019-05-29 12:22:08.000000000 +0800
+++ cacti/include/layout.js     2019-06-02 22:03:12.044034998 +0800
@@ -1975,7 +1975,7 @@
 function ajaxAnchors() {
        var page = basename(location.pathname);

-       $('a.pic, a.linkOverDark, a.linkEditMain, a.console, a.hyperLink, a.tab').not('[href^="http"], [href^="https"], [href^="#"], [target="_blank"]').off('click').on('click', function(event) {
+       $('a.pic, a.linkOverDark, a.linkEditMain, a.console, a.hyperLink, a.tab').not('[href^="http"], [href^="https"], [href^="mailto"], [href^="#"], [target="_blank"]').off('click').on('click', function(event) {
                event.preventDefault();
                event.stopPropagation();
@ddb4github ddb4github changed the title Req: ajaxAnchors should ignore more protocol like 'mailto' Req: ajaxAnchors should ignore more hyperlink protocol like 'mailto' Jun 2, 2019
@netniV netniV changed the title Req: ajaxAnchors should ignore more hyperlink protocol like 'mailto' When links are convert to ajax calls, some mail and other links should not be included Jun 7, 2019
@netniV netniV changed the title When links are convert to ajax calls, some mail and other links should not be included When links are convert to ajax calls, mail and some other types should not be included Jun 7, 2019
@netniV netniV changed the title When links are convert to ajax calls, mail and some other types should not be included When links are convert to ajax calls, mailto links should not be included Jun 7, 2019
@netniV netniV closed this as completed in 42c9a9c Jun 7, 2019
@netniV netniV added this to the v1.2.4 milestone Jun 7, 2019
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Jun 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants