Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to file lib/poller.php from release 1.2.18 to 1.2.19 introduced a bug that lead to problem reported in issue #4460 #4490

Closed
chassepa opened this issue Dec 3, 2021 · 2 comments
Labels
bug Undesired behaviour unverified Some days we don't have a clue

Comments

@chassepa
Copy link

chassepa commented Dec 3, 2021

From release 1.2.18 to 1.2.19 the following change has been done to file lib/poller.php:

    554c577,581
    < 		if ($remainder && $limit != '') {
    ---
    > 		$rows = db_fetch_cell('SELECT COUNT(local_data_id)
    > 			FROM poller_output');
    > 
    > 		/* to much records in poller_output, process in chunks */
    > 		if ($rows && $remainder) {

I believe there is something wrong with the new test:

if ($rows && $remainder) {

which make the poller to enter into an infinite loop.

On our installation I changed it back to the old test:

if ($remainder && $limit != '') {

and it fixed the problem.

@chassepa chassepa added bug Undesired behaviour unverified Some days we don't have a clue labels Dec 3, 2021
@netniV
Copy link
Member

netniV commented Dec 3, 2021

I believe that was already addressed in #4460

@chassepa
Copy link
Author

chassepa commented Dec 3, 2021

@netniV You are right I should have written my comment directly in #4460. I close this issue.

@chassepa chassepa closed this as completed Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour unverified Some days we don't have a clue
Projects
None yet
Development

No branches or pull requests

2 participants