Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] 1.20 ? #95

Open
HowardZHY opened this issue Jun 9, 2023 · 10 comments
Open

[Question] 1.20 ? #95

HowardZHY opened this issue Jun 9, 2023 · 10 comments

Comments

@HowardZHY
Copy link

Will it update to 1.20?

@TheUserCreated
Copy link

1.20 dramatically improved the performance of the lighting engine. There hasn't been an official yes or no as to whether phosphor will be updating, but I wouldn't bet on it at this time

@PweSol
Copy link

PweSol commented Jun 10, 2023

1.20 vanilla is basically a copy of Starlight. Phosphor is technically inferior so there is no point updating it.

@64BitUniverse
Copy link

Who knows, there could still be improvements to be made somewhere

@NotLicense14
Copy link

I would love to see Phosphor be updated to 1.20[.1],

@mrjasonn
Copy link

mrjasonn commented Jun 24, 2023

@HowardZHY Phosphor is not needed as Minecraft 1.20 hugely optimised the lighting engine. It’s still not as fast as Starlight, but it is much faster and much closer to Starlight speeds because it has more checks for stability purposes (which Minecraft being bug free is important!)

@HowardZHY
Copy link
Author

HowardZHY commented Jun 24, 2023

@HowardZHY Phosphor is not needed as Minecraft 1.20 hugely optimised the lighting engine. It’s still not as fast as Starlight, but it is much faster and much closer to Starlight speeds because it has more checks for stability purposes (which Minecraft being bug free is important!)

I just wonder if there could still be improvements to be made somewhere

@astridellensdottir
Copy link

Maybe you can find those possible improvements and submit a PR, then. There’s no need for phosphor to update past 1.19 right now, as the lighting engine it improved has been entirely replaced in 1.20 vanilla with one that’s significantly faster than 1.19 with phosphor, and more stable than 1.19 with starlight. The old optimizations no longer apply, and new ones haven’t yet been found.

@42Willow
Copy link

@jellysquid3
Copy link
Member

jellysquid3 commented Jun 25, 2023

We don't know if there will be a port of MC 1.20. Right now, most of Phosphor's patches are rendered broken and/or obsolete. It remains to be seen if there are any significant optimizations which exist for the newer lighting engine that are useful outside of very large servers.

I wouldn't expect a "port" any time soon. If there is an update, it would likely look very different compared to earlier releases.

@13Ralef
Copy link

13Ralef commented Mar 8, 2024

Will it update to 1.20?

No, because 1.20 has improved it's lightning engine performance dramatically, so phosphor it not necessary anymore I'm those versions, Neither does Starlight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

10 participants