-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with Emotecraft #2371
Comments
The mod author can set a mixin rule to disable Not really sure why this mod is broken. Sodium should just be rendering what it's asked to. Needs investigation. |
EmoteCraft replaces the quads in cuboids with its own when playing the bending animation, which is not possible while sodium completely replaces cuboids But they have a second way where they just replace the Cuboid render with their own, which also doesn't work with sodium because sodium overrides the vanilla renderer calls. This all works by redirecting the render in ModelPart, which is exactly what was overridden by sodium |
Hmmm... we'll have to figure out some kind of interface they can use then. I don't see a way to avoid a conflict here otherwise. Suggestions welcome. |
I'm very busy (and will be for some time), but I can make a compatibility mode (make my mod use sodium if sodium is loaded, or behave normal otherwise) |
Bug Description
Using the Emotecraft mod 2.2.5 and Sodium 0.5.6+ or 0.5.8 the following happens: the bones in the elbows and knees disappear. Animations stop looking beautiful. The animation used is the same. This error occurs starting from version 0.5.6. It is also present in the newest version at the moment, 0.5.8.
Emotecraft : https://github.com/KosmX/emotes/releases/tag/2.2.5
It will be more clear to look at the screenshots:
0.5.3
0.5.6+ or 0.5.8
Reproduction Steps
Log File
latest.log
Crash Report
crash-2024-03-09_13.27.56-client.txt
The text was updated successfully, but these errors were encountered: