Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness slider description is wrong and misleading #2347

Open
EminGT opened this issue Feb 19, 2024 · 2 comments · May be fixed by #2388
Open

Brightness slider description is wrong and misleading #2347

EminGT opened this issue Feb 19, 2024 · 2 comments · May be fixed by #2388
Labels
F-good-first-issue Flag: Good first issue for new contributors T-bug Type: Bug

Comments

@EminGT
Copy link

EminGT commented Feb 19, 2024

Bug Description

Sodium shows the following tooltip when hovering over the Brightness slider:
"Controls the brightness (gamma) of the game."

This makes no sense because Minecraft's Brightness slider has nothing to do with gamma. It's instead a slider that changes lighting intensity according to user preference.

This text should be replaced with something like this example:
"Controls the lighting intensity in darker areas of the game. Well lit areas are not affected."

Reproduction Steps

Go to Video Settings and hover your mouse over the Brightness slider.

Log File

Crash Report

@EminGT EminGT added the S-needs-triage Status: Needs triage label Feb 19, 2024
@Julienraptor01
Copy link

the setting is called gamma in the options.txt tho https://minecraft.wiki/w/Options.txt#:~:text=gamma

@jellysquid3
Copy link
Member

It wasn't the intention to communicate that the brightness slider was the gamma slider, but rather that it is also called gamma in some languages and within the code.

But yes, it's not a gamma slider (even if Minecraft calls it that.) We should probably use less confusing language.

@jellysquid3 jellysquid3 added T-bug Type: Bug F-good-first-issue Flag: Good first issue for new contributors and removed S-needs-triage Status: Needs triage labels Feb 19, 2024
@esoccoli esoccoli linked a pull request Mar 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-good-first-issue Flag: Good first issue for new contributors T-bug Type: Bug
Development

Successfully merging a pull request may close this issue.

3 participants