Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating graphics drivers for Intel Gen7 GPUs does not solve the startup crash #2432

Open
rocketguedes opened this issue Apr 25, 2024 · 12 comments
Labels
A-drivers Area: Driver compatibility P-high Priority: High S-confirmed Status: Confirmed T-bug Type: Bug
Milestone

Comments

@rocketguedes
Copy link

Bug Description

I cant start minecraft cause show this error telling me i have old driver for Intel, but I have a dedicated NVIDIA GTX 1050 ti, idk why sodium is using the integrated GPU, or caring about that.

My CPU i5 3570 have a HD Graphics 2500, but im not using it. Has no HDMI connect to it. I just use the QSV on OBS.

Captura de tela 2024-04-25 161739

Reproduction Steps

Just start from the Official Minecraft Launcher (Fabric Loader + Fabric API + Sodium + Iris)

Log File

latest.log

Crash Report

no crash report, game not start

@rocketguedes rocketguedes added the S-needs-triage Status: Needs triage label Apr 25, 2024
@pajicadvance pajicadvance added T-bug Type: Bug P-high Priority: High A-drivers Area: Driver compatibility S-confirmed Status: Confirmed and removed S-needs-triage Status: Needs triage labels Apr 25, 2024
@pajicadvance
Copy link
Member

We're already aware of this problem - a fix is currently in the works.

@jellysquid3
Copy link
Member

The bug report's assumption as written is not correct. The problem is that Minecraft 1.20.5 changed the version of Oshi being used, and it now returns different version strings which Sodium doesn't know how to deal with. Not helping matters is that Intel uses both 10.18.10.5161 and 15.33.53.5161 in different places (why?!) to mean the same thing.

@jellysquid3 jellysquid3 changed the title Error on start: Sodium caring about the iGPU instead the dGPU Updating graphics drivers for Intel Gen7 GPUs does not solve the startup crash Apr 26, 2024
@jellysquid3 jellysquid3 added this to the Sodium 0.5.9 milestone Apr 26, 2024
@rocketguedes
Copy link
Author

rocketguedes commented Apr 26, 2024

The bug report's assumption as written is not correct. The problem is that Minecraft 1.20.5 changed the version of Oshi being used, and it now returns different version strings which Sodium doesn't know how to deal with. Not helping matters is that Intel uses both 10.18.10.5161 and 15.33.53.5161 in different places (why?!) to mean the same thing.

You're right! Using ATlauncher I created a 1.20.4 instance using the latest available mods versions and it has been started as expected with no crashes. The crash only happens in version 1.20.5.

@StShAzzy

This comment was marked as abuse.

@StShAzzy

This comment was marked as abuse.

@Felix14-v2
Copy link

Create a PR if this is so simple...

@StShAzzy

This comment was marked as abuse.

@IMS212
Copy link
Member

IMS212 commented May 7, 2024

The problem is that at the point this check runs, we cannot know what GPU Minecraft is running on. It's not smart to assume it's running on the better GPU.

@StShAzzy

This comment was marked as abuse.

@IMS212
Copy link
Member

IMS212 commented May 7, 2024

There is a config. You can pass in -Dsodium.checks.win32.intelGen7=false.

@StShAzzy

This comment was marked as abuse.

@jellysquid3
Copy link
Member

You can be frustrated about not being able to use the mod due to a bug. But going on a tirade about how you supposedly know better, while having zero context as to why the code is written that way or the problems involved, is unacceptable.

The problem is not that we do not check for multiple GPUs. The problem is that OSHI (code that we do not write, and for which Minecraft updated) has changed the way they provide information about GPUs, and it no longer works reliably or returns the correct information. We have to replace a lot of code to fix these problems correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-drivers Area: Driver compatibility P-high Priority: High S-confirmed Status: Confirmed T-bug Type: Bug
Development

No branches or pull requests

6 participants