Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request permissions result listener when activity re-attached #515

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Add request permissions result listener when activity re-attached #515

merged 2 commits into from
Jun 2, 2021

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jun 1, 2021

Fix #355 .

  • Remove deprecated registerWith.
  • Release plugin instance when detached from the engine.
  • Extract the add listener's method.

@AlexV525 AlexV525 requested a review from CaiJingLong June 1, 2021 14:48
@CaiJingLong
Copy link
Member

There is a risk of memory leakage, and I will submit a commit in the pull request to solve it.

@CaiJingLong
Copy link
Member

@AlexV525
You can review my commit.

I added some code to remove the listener from the old binding when reattaching.

@AlexV525
Copy link
Member Author

AlexV525 commented Jun 2, 2021

LGTM

@AlexV525 AlexV525 merged commit b0bf2c8 into master Jun 2, 2021
@AlexV525 AlexV525 deleted the fix-activity-reattach branch June 8, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaiJingLong CaiJingLong Awaiting requested review from CaiJingLong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]fun onReattachedToActivityForConfigChanges(binding: ActivityPluginBinding) not handled
2 participants
@AlexV525 @CaiJingLong