Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty migration class should not be generated #191

Closed
ravage84 opened this issue Oct 16, 2014 · 2 comments
Closed

Empty migration class should not be generated #191

ravage84 opened this issue Oct 16, 2014 · 2 comments

Comments

@ravage84
Copy link
Contributor

It happens that I generate the schema migration and since there is no change in the db (for whatever reason), it generates me an empty skeleton migration class file.

This situation should be caught and either:
a) no schema migrations class should be generated
or
b) the user should be asked what to do.

May be there is a use case for an empty migration class, but I haven't come accross it.

@deizel
Copy link
Contributor

deizel commented Oct 18, 2014

Nice idea - this should be solved now for both a) and b) because the shell already asks this question:

Do you want compare the schema.php file to the database? (y/n)

Answering no will get you a blank template (if needed), and yes will compare and exit if nothing to do.

@ravage84
Copy link
Contributor Author

🆒 stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants