Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show logs while running for long running jobs #881

Merged
merged 2 commits into from
Oct 3, 2016
Merged

Show logs while running for long running jobs #881

merged 2 commits into from
Oct 3, 2016

Conversation

Sumukh
Copy link
Member

@Sumukh Sumukh commented Sep 28, 2016

Resolves #880

@Sumukh Sumukh changed the title Show logs periodically for long running jobs Show logs while running for long running jobs Sep 28, 2016
@knrafto
Copy link
Contributor

knrafto commented Sep 28, 2016

I don't like this approach - you have to remember to take in the show_log function as an argument and call it when you need to.

Maybe we can spawn a background thread for each job that periodically updates the log, and terminates when the job is complete.

knrafto
knrafto suggested changes Sep 28, 2016
View reviewed changes
Copy link
Contributor

@knrafto knrafto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

knrafto
knrafto approved these changes Sep 28, 2016
View reviewed changes
Copy link
Contributor

@knrafto knrafto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but this approach is way better

@Sumukh Sumukh merged commit 5cfd9bb into master Oct 3, 2016
@Sumukh Sumukh deleted the enhancement/sumukh/show_log branch October 3, 2016 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knrafto knrafto knrafto approved these changes

Assignees

@knrafto knrafto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sumukh @knrafto