Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go-to #use'd library or file #20

Closed
ishantheperson opened this issue Dec 28, 2019 · 1 comment
Closed

Go-to #use'd library or file #20

ishantheperson opened this issue Dec 28, 2019 · 1 comment
Labels
enhancement Improvement to existing feature good first issue Good for newcomers
Milestone
2.0 Release

Comments

@ishantheperson
Copy link
Collaborator

It would be nice to be able to click on #use <string> or something and to jump to that file. Right now you can only click on function names, types, etc.

This should be pretty easy to implement - they are already parsed into PragmaUseLib or PragmaUseFile, you just need to update ast-search.ts and onDefinition in server.ts to recognize them. See parse.ts for an example of how to find library locations
@ishantheperson ishantheperson added enhancement Improvement to existing feature good first issue Good for newcomers labels Dec 28, 2019
@ishantheperson ishantheperson added this to the 2.0 Release milestone Jan 20, 2020
@ishantheperson
Copy link
Collaborator Author

Implemented by 56529a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing feature good first issue Good for newcomers
Projects
None yet
Milestone
2.0 Release
Development

No branches or pull requests
1 participant
@ishantheperson