Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension breaks with paths that contain parentheses on Mac #40

Closed
SiddharthParatkar opened this issue Feb 23, 2020 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@SiddharthParatkar
Copy link

When opening a file which relies on another file in a directory with parentheses in its path, the file fails to parse.

@ishantheperson ishantheperson added the bug Something isn't working label Feb 23, 2020
@ishantheperson
Copy link
Collaborator

I think it's something to do with this line

const usedURI = url.pathToFileURL(usedPath).toString().replace(/\/(.):/, (_: string, driveName: string) => `/${driveName}%3A`);

We need to be able to handle arbitrary URL encoded sequences

@ishantheperson
Copy link
Collaborator

@ishantheperson
Copy link
Collaborator

The problem is that in the cache, we sometimes add the URI-encoded version of the path and sometimes add the regular string. This inconsistency can cause a file to be loaded twice, which can then cause compilation to mysteriously fail

@ishantheperson
Copy link
Collaborator

Should be fixed now, need to test on windows

@ishantheperson
Copy link
Collaborator

Fixed on both windows/mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants