Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements #4

Closed
jansowinski opened this issue Feb 26, 2018 · 3 comments
Closed

Updating requirements #4

jansowinski opened this issue Feb 26, 2018 · 3 comments

Comments

@jansowinski
Copy link
Contributor

jansowinski commented Feb 26, 2018

Hi, great project!

I think it'll be worth adding two requirements to README:

  • chromedriver - after just cloning repo, typing bundle and ruby run.rb I got errors about not having chromedriver in PATH, I think I'ts worth adding info about that to tutorial - it'll save some time to newcomers.
  • If you have selected language other than English (UK) in facebook settings, this script won't work (see undefined method `location_once_scrolled_into_view' for nil:Nil #5 and PR connected with that), so I think it's woth adding line about it to requirements

[edited] - it's more informative now :)

@Calamari
Copy link
Owner

Both are good ideas, will do those in the evening :)

@Calamari
Copy link
Owner

So, I just added some lines about selenium and the language. You think it is good enough [tm] now?

@jansowinski
Copy link
Contributor Author

It's great now! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants