New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change detX constraint to use rescale_eigenvalues #297

Open

charlesmartin14 opened this issue Oct 13, 2023 · 0 comments

Member

charlesmartin14 commented Oct 13, 2023

TO make the code clearer, we should change:

def detX_constraint(evals, rescale=True):
  ...
    
    if rescale:
        Wnorm = np.sqrt(np.sum(evals))
        Wscale = np.sqrt(num_evals)/Wnorm 
        evals = (Wscale*Wscale)*evals

To use rescale_eigenvalues() directly


def detX_constraint(evals, rescale=True):
  ...
    
    if rescale:
        evals = rescale_eigenvalues(evals)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment