Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker field shows color code only #1683

Closed
101010f opened this issue Jun 18, 2017 · 6 comments
Closed

Color picker field shows color code only #1683

101010f opened this issue Jun 18, 2017 · 6 comments
Assignees
Labels
Bug Has PR Bug/Feature with a PR created for it. Needs Research

Comments

@101010f
Copy link
Contributor

101010f commented Jun 18, 2017

version 1.5.1

Is this how the color picker should render? I remember having a color preview on one of the sides beside the color hex code.

Using default theme and disabled all plugins.

sketch

@Shelob9 Shelob9 self-assigned this Jun 20, 2017
@Shelob9 Shelob9 added this to the 1.5.2 milestone Jun 20, 2017
@Shelob9
Copy link
Collaborator

Shelob9 commented Jun 21, 2017

Yes, that is how it did work in CF 1.4

@Shelob9
Copy link
Collaborator

Shelob9 commented Jun 21, 2017

Funny thing is that the span to show it is there, and the CSS that should make it shown is there... We did change in 1.5.1 how it gets instantiated. Before no settings were passed, now all settings are passed as default and there is a filter, which is cool, but like would be cooler if it worked.

@Shelob9 Shelob9 modified the milestones: 1.5.2, 1.5.3 Jun 27, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.3, 1.5.4 Jul 23, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.4, 1.5.5 Aug 1, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.5, 1.5.6 Aug 17, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.6, 1.5.7 Sep 4, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.7, 1.5.8 Oct 31, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.8, 1.5.9 Dec 12, 2017
@Shelob9 Shelob9 modified the milestones: 1.5.9, 1.6.0 Jan 6, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.0, 1.7.1 May 9, 2018
@101010f
Copy link
Contributor Author

101010f commented May 21, 2018

The color picker seems to be dead for good with the latest update 1.6.3 Only shows a text input field

@Shelob9 Shelob9 modified the milestones: 1.7.1, 1.7.2 Jun 4, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.2, 1.7.3 Jun 25, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.3, 1.7.4 Jul 5, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.4, 1.8.0, 1.8.1 Oct 19, 2018
@hellohamzak
Copy link

is there any update on Color picker i find is not really working at all. on last couple of release with using only twenty seventeen theme & plugin

@Shelob9 Shelob9 modified the milestones: 1.8.1, 1.9.1 Feb 27, 2019
@kjohnson
Copy link
Contributor

@New0 color_picker_init() is targeting .minicolor-picker, which looks to be the class on the wrapper element. Instead, we should be targeting the <input /> element directly.

@New0 New0 added the Has PR Bug/Feature with a PR created for it. label Sep 19, 2019
@New0 New0 modified the milestones: 1.9.1, 1.8.8 Sep 19, 2019
@New0 New0 modified the milestones: 1.8.8, 1.8.9 Nov 11, 2019
@New0
Copy link
Collaborator

New0 commented Dec 10, 2019

Closed via f68e48f

@New0 New0 closed this as completed Dec 10, 2019
@New0 New0 mentioned this issue Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Has PR Bug/Feature with a PR created for it. Needs Research
Projects
None yet
Development

No branches or pull requests

5 participants