Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: DN pipe EN 10255 #16

Open
rddaz2013 opened this issue Feb 21, 2018 · 2 comments
Open

Feature request: DN pipe EN 10255 #16

rddaz2013 opened this issue Feb 21, 2018 · 2 comments

Comments

@rddaz2013
Copy link

Hi,

nice tool great work

Is it possible to implement a further pipe diameter type? aka EN10255

@CalebBell
Copy link
Owner

Hi Rene,

Thanks! Sure it would be possible for someone to add another pipe schedule to fluids. I know there are lots more standards, like for PVC, ABS, cooper tube, and the standards used in different countries. I agree it would be a good feature. I don't have it on my agenda for the moment, but would be happy to merge a good PR with tests. Alternatively, next time I revisit nearest_pipe (if I did get around to increasing the number of supported pipe standards), I would only be able to include EN10255 if I had a copy of the standard as well.

Cheers,
Caleb

@rddaz2013
Copy link
Author

I think i could prepare the EN10255 addition, i see into the pipe.py.
If it is done i make a pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants