Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to upgrade PWA #1426

Open
iamdey opened this issue Jun 11, 2019 · 3 comments
Open

unable to upgrade PWA #1426

iamdey opened this issue Jun 11, 2019 · 3 comments

Comments

@iamdey
Copy link
Member

iamdey commented Jun 11, 2019

cf. https://twitter.com/NokiDev/status/1137338344256528384

when a new version is available, the app cannot be upgraded from a pwa or mobile browser like brave or FF.

@iamdey iamdey added this to Incoming in Beta version via automation Jun 11, 2019
@gdchamal
Copy link
Member

Expose a route /client/version on express server. This route output a simple result :

{"version": "X.Y.Z"}

If when comparing this version value with current one of active client we detect a change, we must start an upgrade process. This update process should not be automatic and displayed to user for validation.

Upgrade process when started must take care of cleaning correctly local cache of previous version

@iamdey iamdey moved this from Incoming to In progress in Beta version Jun 12, 2019
@iamdey
Copy link
Member Author

iamdey commented Jun 12, 2019

I see 2 scenarios:

  1. the release is published while using it
  2. the release has been published before the app (re)load

In first scenario we can notify the user that a new version is available (that's why I talk about a notification) and when the user click upgrade, it simply reload the app.

That brings us to the 2nd scenario, in case of a reload, the actual offline tool (that enables PWA) should use the network and clear the cache.
It looks like this doesn't work correctly.

uml

@iamdey
Copy link
Member Author

iamdey commented Jun 12, 2019

new documentation about pwa in dc04e8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Beta version
  
In progress
Development

No branches or pull requests

2 participants