src: replace message age in chats with username #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the message age in global and private chats with a username stored in the client's `sessionStorage`, which is cleared on closing of the tab/window. Adds a prompt before global chat for entering a username. Signed-off-by: faradaym <rcheyenne.truss@gmail.com>
faradaym
force-pushed
the
chat-improvements
branch
from
cd20947
to
5813e4d
Compare
Signed-off-by: faradaym <rcheyenne.truss@gmail.com>
|
Looks good to me! Can you change the version number to reflect this update? |
|
@tqrahman @knouse1344 Maybe we can test with some ducks and then merge |
knouse1344
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the message age in global and private chat with a username stored in the client's
sessionStorage, which is cleared on closing of the tab/window. Adds a prompt before global chat for entering a username.Known issues:
not been set in this tab sets the username to null
requiredIs this a patch, a minor version change, or a major version change
patch