Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder discovery for dependency scipt #321

Merged

Conversation

faradaym
Copy link
Collaborator

@faradaym faradaym commented Aug 4, 2023

This is a fix for the dependency automation script so that it can dynamically find the libraries folder from the script folder. This PR also adds a requirements.txt for the script according to python standard. Thanks to @amirna2 for this solution!

Is this a patch, a minor version change, or a major version change
Patch.

Signed-off-by: faradaym <rcheyenne.truss@gmail.com>
@faradaym faradaym marked this pull request as ready for review August 4, 2023 20:04
@tqrahman
Copy link
Collaborator

Some of the libraries were already installed in my macOS and it threw an error saying that the directory already exists. Any thoughts on what we should do? Do we ignore the installed packages or do we overwrite them to make sure the version is consistent with CDP?

Traceback (most recent call last):
File "/Users/tqrahman/Documents/Arduino/libraries/ClusterDuck-Protocol/cdp-dependency-automator-script/install-dependencies.py", line 29, in
with open(file_path, 'wb') as file:
IsADirectoryError: [Errno 21] Is a directory: '/Users/tqrahman/Documents/Arduino/libraries/arduino-timer'

However, when I removed the libraries and ran the script again and it worked like a charm!

@TimoWielink TimoWielink merged commit 4b65633 into ClusterDuck-Protocol:master Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants