Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colony metrics route #25

Merged
merged 6 commits into from Jul 12, 2022
Merged

Colony metrics route #25

merged 6 commits into from Jul 12, 2022

Conversation

JonathanScialpi
Copy link
Collaborator

  • colony metrics: example in comments of CropTemplate component, new service, new route
  • readme updates for blockchain
  • moved IFT and Web3 folders under /backend/src/integrations/Blockchain

Copy link
Collaborator

@rayoz12 rayoz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, I just made a comment about wrapping the colony apis (like what's been done for EIS as an example) but if you have time you can have a look at it.

throw new Error("Farmer not found.");
}else{
// connect to Gnosis network with Farmer account
const provider = gnosisConnection();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to create extra work for you, but would it possible to wrap anything related to colony into it's own class? It would make it easier to call from other places but also test and mock colony data. It would really come down to being another class in the web3 folder that wraps around colony's api calls.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss further in a technical call and then I will create a new branch for this if needed. The reason why I'm not sure if its required is because the Colony SDK is already like a wrapper class which makes it easier to interact with colony so another class would be like a wrapper class on top of another wrapper class.

@rayoz12
Copy link
Collaborator

rayoz12 commented Jul 12, 2022

@JonathanScialpi You'll need to rebase before we can merge

Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants