New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colony metrics route #25
Conversation
JonathanScialpi
commented
Jul 8, 2022
- colony metrics: example in comments of CropTemplate component, new service, new route
- readme updates for blockchain
- moved IFT and Web3 folders under /backend/src/integrations/Blockchain
94c9ec2
to
e5b6ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good, I just made a comment about wrapping the colony apis (like what's been done for EIS as an example) but if you have time you can have a look at it.
throw new Error("Farmer not found."); | ||
}else{ | ||
// connect to Gnosis network with Farmer account | ||
const provider = gnosisConnection(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to create extra work for you, but would it possible to wrap anything related to colony into it's own class? It would make it easier to call from other places but also test and mock colony data. It would really come down to being another class in the web3 folder that wraps around colony's api calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss further in a technical call and then I will create a new branch for this if needed. The reason why I'm not sure if its required is because the Colony SDK is already like a wrapper class which makes it easier to interact with colony so another class would be like a wrapper class on top of another wrapper class.
@JonathanScialpi You'll need to rebase before we can merge |
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
Signed-off-by: JonathanScialpi <scialpi27@gmail.com>
e5b6ebc
to
3d2359a
Compare