Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error max payload size exceeded #98

Merged
merged 13 commits into from
Dec 24, 2022
Merged

Conversation

cameri
Copy link
Owner

@cameri cameri commented Dec 24, 2022

Description

  1. Prevents DoS attack when receiving a large payload over websockets
  2. Add Redis env vars to CONFIGURATION.md
  3. Add network.max_payload_size to settings and to CONFIGURATION.md
  4. Add network.remote_ip_header to settings and to CONFIGURATION.md
  5. Add warning about using non-official Docker distributions.
  6. Fix Tor docker compose mounting wrong data folder
  7. Reduce logging causing disk to be filled
  8. Fix incorrent HTTP header being sent for non-WS requests
  9. Fix issue regarding too many event listeners when receiving many subscriptions in rapid succession
  10. Log WebSocket errors properly
  11. Destroy find event query stream instead of ending the stream abruptly to release connection

Related Issue

#95

Motivation and Context

  1. Improve stability
  2. Allow more flexibility to support custom configurations

How Has This Been Tested?

  1. Unit tests
  2. Integration tests

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri linked an issue Dec 24, 2022 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Dec 24, 2022

Pull Request Test Coverage Report for Build 3772618737

  • 30 of 38 (78.95%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 87.09%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/adapters/web-server-adapter.ts 0 2 0.0%
src/adapters/web-socket-adapter.ts 21 27 77.78%
Totals Coverage Status
Change from base Build 3769182359: -0.6%
Covered Lines: 828
Relevant Lines: 935

💛 - Coveralls

@cameri cameri force-pushed the 95-error-max-payload-size-exceeded branch from 220742b to d2317b3 Compare December 24, 2022 17:01
@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.3% 75.3% Coverage
0.0% 0.0% Duplication

@cameri cameri self-assigned this Dec 24, 2022
@cameri cameri added the bug Something isn't working label Dec 24, 2022
@cameri cameri merged commit 57de0fc into main Dec 24, 2022
@cameri cameri deleted the 95-error-max-payload-size-exceeded branch December 24, 2022 20:11
@github-actions
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: max payload size exceeded
2 participants