Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SettingsStatic class default to yaml file #158

Merged
merged 4 commits into from
Feb 5, 2023

Conversation

antonleviathan
Copy link
Collaborator

Description

This patch fixes scenarios where the user renamed the settings file to settings.json.<something> which caused the settings setup script to concatenate the settings name incorrectly

Related Issue

N/A

Motivation and Context

Fixes a bug

How Has This Been Tested?

Local reproduction of issue

Screenshots (if appropriate):

Types of changes

Update of a method, no backward compatiblity implications

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4080304677

  • -3 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 104 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-5.9%) to 53.741%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/settings.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/repositories/event-repository.ts 1 97.44%
src/handlers/event-strategies/replaceable-event-strategy.ts 2 84.62%
src/adapters/web-server-adapter.ts 3 56.67%
src/handlers/event-message-handler.ts 3 85.28%
src/factories/rate-limiter-factory.ts 4 45.45%
src/app/worker.ts 5 34.29%
src/cache/client.ts 5 40.0%
src/adapters/redis-adapter.ts 6 6.38%
src/handlers/request-handlers/rate-limiter-middleware.ts 8 17.5%
src/utils/settings.ts 10 65.82%
Totals Coverage Status
Change from base Build 4077310695: -5.9%
Covered Lines: 1027
Relevant Lines: 1871

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4095053537

  • 1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
  • 90 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.7%) to 58.999%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/app.ts 0 1 0.0%
src/utils/settings.ts 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
src/repositories/event-repository.ts 1 98.72%
src/routes/invoices/index.ts 1 80.0%
src/app/worker.ts 2 51.43%
src/factories/worker-factory.ts 2 90.32%
src/utils/settings.ts 7 72.15%
src/controllers/callbacks/zebedee-callback-controller.ts 8 16.13%
src/adapters/web-socket-server-adapter.ts 9 74.63%
src/handlers/event-message-handler.ts 12 86.59%
src/app/app.ts 15 16.0%
src/adapters/web-socket-adapter.ts 16 56.67%
Totals Coverage Status
Change from base Build 4077310695: -0.7%
Covered Lines: 1167
Relevant Lines: 1951

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

@cameri cameri merged commit 7a4667c into main Feb 5, 2023
@cameri cameri deleted the fix/static-settings-error branch February 5, 2023 05:09
github-actions bot pushed a commit that referenced this pull request Feb 5, 2023
## [1.22.1](v1.22.0...v1.22.1) (2023-02-05)

### Bug Fixes

* Dockerfile.test to reduce vulnerabilities ([#170](#170)) ([a0dcc05](a0dcc05))
* SettingsStatic class default to yaml file ([#158](#158)) ([7a4667c](7a4667c))
* update supported nips in readme ([#164](#164)) ([a0ff972](a0ff972))
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

🎉 This PR is included in version 1.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

antonleviathan added a commit that referenced this pull request Feb 8, 2023
* fix: default to yaml file

* fix: intg tests failing

* fix: disable watch settings on tests

* style: lix fint

---------

Co-authored-by: Ricardo Arturo Cabral Mejía <me@ricardocabral.io>
antonleviathan pushed a commit that referenced this pull request Feb 8, 2023
## [1.22.1](v1.22.0...v1.22.1) (2023-02-05)

### Bug Fixes

* Dockerfile.test to reduce vulnerabilities ([#170](#170)) ([a0dcc05](a0dcc05))
* SettingsStatic class default to yaml file ([#158](#158)) ([7a4667c](7a4667c))
* update supported nips in readme ([#164](#164)) ([a0ff972](a0ff972))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants