-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SettingsStatic class default to yaml file #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4080304677
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4095053537
💛 - Coveralls |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 1.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
antonleviathan
added a commit
that referenced
this pull request
Feb 8, 2023
* fix: default to yaml file * fix: intg tests failing * fix: disable watch settings on tests * style: lix fint --------- Co-authored-by: Ricardo Arturo Cabral Mejía <me@ricardocabral.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes scenarios where the user renamed the settings file to
settings.json.<something>
which caused the settings setup script to concatenate the settings name incorrectlyRelated Issue
N/A
Motivation and Context
Fixes a bug
How Has This Been Tested?
Local reproduction of issue
Screenshots (if appropriate):
Types of changes
Update of a method, no backward compatiblity implications
Checklist: