Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: zebedee callback not marking invoice as paid #318

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: zebedee callback not marking invoice as paid #318

merged 1 commit into from
May 25, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented May 25, 2023

Description

  1. Fix Zebedee callback incorrectly passing confirmedAt when confirming invoice

Related Issue

#317

Motivation and Context

  1. Nostream v1.25.0 with zebedee as payments processor fails to confirm invoice

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri self-assigned this May 25, 2023
@cameri cameri linked an issue May 25, 2023 that may be closed by this pull request
Zebedee callback fails to mark invoice as completed #317
Closed
@cameri cameri added the bug Something isn't working label May 25, 2023
@cameri cameri merged commit a2670d0 into main May 25, 2023
6 checks passed
@cameri cameri deleted the 317-zebedee-callback-fails-to-mark-invoice-as-completed branch May 25, 2023 01:13
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-actions bot pushed a commit that referenced this pull request May 25, 2023
@semantic-release-bot
chore(release): 1.25.1 [skip ci]
7969701 
## [1.25.1](v1.25.0...v1.25.1) (2023-05-25)

### Bug Fixes

* zebedee callback not marking invoice as paid ([#318](#318)) ([a2670d0](a2670d0))
@github-actions
Copy link

🎉 This PR is included in version 1.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cameri cameri

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zebedee callback fails to mark invoice as completed
1 participant
@cameri