Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Bug #2

Merged
merged 1 commit into from Feb 16, 2022
Merged

Fixed: Bug #2

merged 1 commit into from Feb 16, 2022

Conversation

oggy107
Copy link
Contributor

@oggy107 oggy107 commented Feb 16, 2022

Bug: Again the bug is app crashed when user press enter with a space or spaces in search input.
Fix: Trim down the trailing and leading spaces from search

Bug: Again the bug is app crashed when user press enter with a space or spaces in search input. Fix: trim down the trailing and leading spaces from search
@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for pokepoke-search ready!

🔨 Explore the source changes: 4d210f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/pokepoke-search/deploys/620c7d2b1950460008d9291c

😎 Browse the preview: https://deploy-preview-2--pokepoke-search.netlify.app/

@CamiloBarros CamiloBarros merged commit 82a7279 into CamiloBarros:master Feb 16, 2022
@CamiloBarros
Copy link
Owner

CamiloBarros commented Feb 16, 2022

Hi, I don't understand what you are saying about the API only accepting numbers and why it is redundant, I have been following the documentation and it tells me that I can send both identifiers and names. Maybe I could be confused and I am missing something.
I should mention that the idea of the project is to be searchable by name and not exclusively by identifier.

@oggy107
Copy link
Contributor Author

oggy107 commented Feb 16, 2022

Hi, I don't understand what you are saying about the API only accepting numbers and why it is redundant, I have been following the documentation and it tells me that I can send both identifiers and names. Maybe I could be confused and I am missing something. I should mention that the idea of the project is to be searchable by name and not exclusively by identifier.

Thats my bad. I did not know the names works too. In that case current check is fine. Again sorry for my previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants